Skip to content

SameSite cookie attribute can be configured for JS tracker #16733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2020
Merged

SameSite cookie attribute can be configured for JS tracker #16733

merged 3 commits into from
Nov 17, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 17, 2020 •
edited
Loading

Description:

follow up from #16724 #16724

fix #16161

Thanks to @beger and @fealXX

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Copy link
Member Author

tsteur commented Nov 17, 2020

fyi updated the JS API reference and created https://matomo.org/faq/how-to/how-do-i-track-a-website-within-an-iframe/

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 17, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 17, 2020

build js

@tsteur tsteur merged commit cd6708f into 4.x-dev Nov 17, 2020
@tsteur tsteur deleted the m16724 branch November 17, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New visitor ID generated per action in iframes (SameSite cookie issue)
2 participants
@tsteur @fealXX