Skip to content

Conversation

diosmosis
Copy link
Member

… to observe less concurrency issues

Refs matomo-org/plugin-CustomAlerts#67

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 31, 2020
@diosmosis diosmosis added this to the 4.0.0-RC milestone Oct 31, 2020
@@ -143,4 +140,12 @@ public function taskHasBeenScheduledOnce($taskName)
{
return isset($this->timetable[$taskName]);
}

public function readFromOption()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like refresh would be a better name.

@tsteur tsteur merged commit 5575310 into 4.x-dev Nov 1, 2020
@tsteur tsteur deleted the task-timetable-read-more branch November 1, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

3 participants