Skip to content

Adds additional system check for CREATE TEMPORARY TABLES permission #15139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2020
Merged

Adds additional system check for CREATE TEMPORARY TABLES permission #15139

merged 6 commits into from
Jan 22, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 10, 2019 •
edited
Loading

Also hides the LOAD DATA INFILE check if that feature is disabled in config

fixes #15132
fixes #15115
refs #15084

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 10, 2019
@tsteur tsteur added this to the 4.0.0 milestone Nov 10, 2019
@tsteur tsteur modified the milestones: 4.0.0, 4.1.0 Nov 10, 2019
mattab
mattab reviewed Dec 5, 2019
View reviewed changes
@sgiehl sgiehl force-pushed the temporarytableperm branch from d3d0c0f to 22b61b6 Compare December 9, 2019 07:55
@sgiehl sgiehl changed the base branch from 3.x-dev to 4.x-dev January 16, 2020 16:34
@sgiehl sgiehl force-pushed the temporarytableperm branch 2 times, most recently from e8b0994 to 29909b7 Compare January 17, 2020 21:01
@tsteur
Copy link
Member

tsteur commented Jan 20, 2020

👍
works
image
Seems there is no screenshot for system check? At least nothing is failing. Feel free to merge @sgiehl

@mattab mattab modified the milestones: 4.1.0, 4.0.0 Jan 21, 2020
@sgiehl sgiehl force-pushed the temporarytableperm branch from 29909b7 to 7a8b2eb Compare January 21, 2020 19:45
@sgiehl sgiehl force-pushed the temporarytableperm branch from 7a8b2eb to 0cd19cb Compare January 21, 2020 21:02
@sgiehl
Copy link
Member Author

sgiehl commented Jan 21, 2020

Added a UI test for the diagnostic page. Will merge, once it passed...

@tsteur
Copy link
Member

tsteur commented Jan 21, 2020

👍

@sgiehl sgiehl merged commit 1db55e3 into 4.x-dev Jan 22, 2020
@sgiehl sgiehl deleted the temporarytableperm branch January 22, 2020 08:14
This was referenced Jan 25, 2020
Closed
Closed
@sgiehl sgiehl mentioned this pull request Feb 3, 2020
Closed
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab mattab left review comments

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Extend Diagnostic Checks with Temporary Table Feature of mysql LoadDataInfile Diagnostics Check is done even in config this setting is disabled
3 participants
@sgiehl @tsteur @mattab