Prevent warning array to string conversion in console renderer #15037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://forum.matomo.org/t/notice-array-to-string-conversion-matomo-3-11-0/34644 As we don't have more information yet I couldn't reproduce it. Looking at the code it seems though like some metadata has an array in there. I didn't even quite know we had this renderer and from what I can see we're using it to convert a dataTableMap to a string. Not sure when and why. It should fix the warning though.
|
BTW I was seeing this error heaps of times in the logs. Noticed it comes from twig when checking if an object is empty in the dataTable twig
|
tsteur
added a commit
that referenced
this pull request
Oct 23, 2019
This was referenced Oct 23, 2019
diosmosis
pushed a commit
that referenced
this pull request
Nov 6, 2019
See https://forum.matomo.org/t/notice-array-to-string-conversion-matomo-3-11-0/34644 As we don't have more information yet I couldn't reproduce it. Looking at the code it seems though like some metadata has an array in there. I didn't even quite know we had this renderer and from what I can see we're using it to convert a dataTableMap to a string. Not sure when and why. It should fix the warning though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.matomo.org/t/notice-array-to-string-conversion-matomo-3-11-0/34644
As we don't have more information yet I couldn't reproduce it. Looking at the code it seems though like some metadata has an array in there. I didn't even quite know we had this renderer and from what I can see we're using it to convert a dataTableMap to a string. Not sure when and why. It should fix the warning though.