-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Remove gears detection #15956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gears detection #15956
Conversation
Merge from origin
Use 0 as default Co-Authored-By: Stefan Giehl <stefan@matomo.org>
51164c2
to
38ca22e
Compare
I've gone through the changes again and reviewed them. There were some tests failing and various changes missing in other repos (see linked PRs). Would be good if someone else could quickly look through the changes. And just to point it out again. These changes will drop the column that was used to store the gears detection. But as it wasn't possible to segment for that and there shouldn't have many detections been positive in the past anymore, I think we can remove that. Already processed reports might still show gears, only new reports won't contain it anymore... |
@sgiehl not sure if this needs another review from someone else as you reviewed it initially? |
@tsteur If removing the column is fine, guess it should be enough to have a look at the linked PRs and maybe the changes I've added to this PR |
Had a quick look and looks all good @sgiehl 👍 |
cheers @pebosi for the initial work
replaces #15627