Skip to content

Remove gears detection #15956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 20, 2020
Merged

Remove gears detection #15956

merged 25 commits into from
May 20, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 15, 2020

cheers @pebosi for the initial work

replaces #15627

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 15, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone May 15, 2020
@sgiehl
Copy link
Member Author

sgiehl commented May 15, 2020

I've gone through the changes again and reviewed them. There were some tests failing and various changes missing in other repos (see linked PRs). Would be good if someone else could quickly look through the changes.

And just to point it out again. These changes will drop the column that was used to store the gears detection. But as it wasn't possible to segment for that and there shouldn't have many detections been positive in the past anymore, I think we can remove that. Already processed reports might still show gears, only new reports won't contain it anymore...

@tsteur
Copy link
Member

tsteur commented May 18, 2020

@sgiehl not sure if this needs another review from someone else as you reviewed it initially?

@sgiehl
Copy link
Member Author

sgiehl commented May 19, 2020

@tsteur If removing the column is fine, guess it should be enough to have a look at the linked PRs and maybe the changes I've added to this PR

@tsteur
Copy link
Member

tsteur commented May 19, 2020

Had a quick look and looks all good @sgiehl 👍

@sgiehl sgiehl merged commit 4afbe93 into 4.x-dev May 20, 2020
@sgiehl sgiehl deleted the pebosi-remove-gears branch May 20, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

4 participants