Skip to content

Rename interaction_position to pageview_position #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2020
Merged

Rename interaction_position to pageview_position #15812

merged 6 commits into from
Apr 15, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 14, 2020

fixes #12124

@sgiehl sgiehl added this to the 4.0.0 milestone Apr 14, 2020
This was referenced Apr 14, 2020
Merged
Merged
@sgiehl sgiehl force-pushed the pageviewposition branch from c1cc387 to 67c11ad Compare April 14, 2020 12:25
@sgiehl sgiehl marked this pull request as ready for review April 14, 2020 12:47
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 14, 2020
diosmosis
diosmosis reviewed Apr 14, 2020
View reviewed changes
diosmosis
diosmosis approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a new issue might be needed for interaction_position

@sgiehl sgiehl force-pushed the pageviewposition branch from 8cf91f7 to 5df34cd Compare April 15, 2020 09:09
@sgiehl sgiehl force-pushed the pageviewposition branch from 5df34cd to d4bbdef Compare April 15, 2020 09:55
@sgiehl sgiehl merged commit c4eca98 into 4.x-dev Apr 15, 2020
@sgiehl sgiehl deleted the pageviewposition branch April 15, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Rename log_link_visit_action.interaction_position to eg pageview_position
2 participants
@sgiehl @diosmosis