Skip to content

activate warning for php versions incompatible with next major release #15670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2020
Merged

activate warning for php versions incompatible with next major release #15670

merged 1 commit into from
Mar 7, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 5, 2020

fixes #15623

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 5, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Mar 5, 2020
@sgiehl sgiehl linked an issue Mar 5, 2020 that may be closed by this pull request
Mention require PHP 7.2 in admin notification #15623
Closed
@tsteur
Copy link
Member

tsteur commented Mar 5, 2020

👍 works.

Ideally it would show (PHP 7.3 or newer recommended) as part of the text as well maybe if easily done? Not too important though. I suppose it would maybe invalidate some translations and we're not updating 3.x translations anymore so not needed.

@sgiehl
Copy link
Member Author

sgiehl commented Mar 6, 2020

Correct. That would mean changing translations

@tsteur tsteur merged commit d6df56c into 3.x-dev Mar 7, 2020
@tsteur tsteur deleted the phpwarning branch March 7, 2020 02:39
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@sgiehl @jonasgrilleres
activate warning for php versions incompatible with next major release (
7e7ae31 
matomo-org#15670)
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@sgiehl @jbuget
activate warning for php versions incompatible with next major release (
814a70a 
matomo-org#15670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

Mention require PHP 7.2 in admin notification
2 participants
@sgiehl @tsteur