Skip to content

respect max execution time limit for transitions plugin #15652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2020
Merged

respect max execution time limit for transitions plugin #15652

merged 5 commits into from
Mar 15, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 3, 2020

fixes #15609

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 3, 2020
@sgiehl sgiehl added this to the 3.13.4 milestone Mar 3, 2020
@sgiehl sgiehl linked an issue Mar 3, 2020 that may be closed by this pull request
Limit max execution time of transitions feature #15609
Closed
diosmosis
diosmosis reviewed Mar 5, 2020
View reviewed changes
diosmosis
diosmosis reviewed Mar 5, 2020
View reviewed changes
@diosmosis
Copy link
Member

Code looks good to me but I'm not too familiar with the related code, so I think @tsteur may want to take a look as well

tsteur
tsteur reviewed Mar 5, 2020
View reviewed changes
@tsteur
Copy link
Member

tsteur commented Mar 5, 2020

Looks good. Left one comment. Haven't tested it though. Be good to make sure some error message will be shown in the UI if the query fails because of a timeout similar to Visitor Log. I suppose that's what happens automatically anyway. Just need to see how it behaves when it's used in transitions eg through a row action

@sgiehl sgiehl force-pushed the transitionsexecutiontime branch from ace34e3 to 05b7cb3 Compare March 6, 2020 14:54
@sgiehl
Copy link
Member Author

sgiehl commented Mar 6, 2020

@tsteur it show the exception in the overlay if loading a transition through a row action:

image

@tsteur
Copy link
Member

tsteur commented Mar 8, 2020

@sgiehl I just tested it and it doesn't work. That's because the ranking query will be applied and therefore it's not after the first select.
Not sure how it works for you? Cause they all have ranking query set?

This is my setting

live_query_max_execution_time = 0.001

@tsteur
Copy link
Member

tsteur commented Mar 9, 2020

btw we could in worst case move this out of 3.13.4 into 3.13.5 if we wanted to release 3.13.4 earlier

@sgiehl sgiehl force-pushed the transitionsexecutiontime branch from ba218c1 to 629c1df Compare March 15, 2020 14:38
@sgiehl
Copy link
Member Author

sgiehl commented Mar 15, 2020

@tsteur updated the code so it works with the ranking query correctly.

@tsteur tsteur merged commit c7dc542 into 3.x-dev Mar 15, 2020
@tsteur tsteur deleted the transitionsexecutiontime branch March 15, 2020 19:35
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@sgiehl @jonasgrilleres
respect max execution time limit for transitions plugin (matomo-org#1…
422a643 
…5652)
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@sgiehl @jbuget
respect max execution time limit for transitions plugin (matomo-org#1…
ca283c3 
…5652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

Limit max execution time of transitions feature
3 participants
@sgiehl @diosmosis @tsteur