Do not record the stack trace for user input errors #15576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up from #14771 Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
sgiehl
approved these changes
Feb 17, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
Follow up from matomo-org#14771 Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Follow up from matomo-org#14771 Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #14771
Have been debugging and the above PR alone did not help since the
PsrLogMessageProcessorwould call the toString method of the exception and add the message again. This makes sure the logs are more readble.