Skip to content

Support goal metrics for browser name dimension #15409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2020
Merged

Support goal metrics for browser name dimension #15409

merged 4 commits into from
Jan 26, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 17, 2020 •
edited
Loading

replaces #13443
fix #13202

This PR will create a column in the conversion table and therefore we need to do it in a Matomo 4.0 release.

@sgiehl fyi had somehow trouble pushing into the other branch so creating a new one where I will be fixing the tests

Fixing custom dimensions test might be easier after merging

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 17, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jan 17, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 17, 2020
sgiehl
sgiehl requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, but some tests are still failing and need some more adjustments...

@tsteur tsteur merged commit d3aabbd into 4.x-dev Jan 26, 2020
@tsteur tsteur deleted the goalmetrics branch January 26, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Show "browser" report in goal by dimension report, view conversion rates by browser
2 participants
@tsteur @sgiehl