Compare segments and periods (in API and UI) #14365
Conversation
…ward query parameters in AJAX requests + allow broadcast to handle multi-value query param values.
…l visits" segment translation and add currently selected segment to comparisons table.
…ults in 100% cpu usage (when reading dataTable param w/ many rows & comparison tables), get overlay/transitions icons to appear, overlay should work properly.
…isons in subtables by forcing idSubtables of comparisons to be sent in request (makes UI work, but not pracitcal for API).
|
FYI @mattab / @tsteur ready for an initial UX review. Comparisons should be integrated in the following ways: -> html table (including actions table + support for subtables) Remaining todo:
|
|
@tsteur Applied the review feedback, will fix the tests now. |
|
@tsteur tests are passing, can give it another review now. |
| } | ||
|
|
||
| console.log(this.multiEvolutionRows, this.multiEvolutionRowsSeries); |
There was a problem hiding this comment.
the console.log should be removed?
| } | ||
|
|
||
| function checkEnabledForCurrentPage() { | ||
| var category = piwikUrl.getSearchParam('category') || piwikUrl.getSearchParam('module'); |
There was a problem hiding this comment.
could you leave a comment when the module/action applies? I suppose it applies when it is widgetized?
There was a problem hiding this comment.
It's for MultiSites, since it uses a module/action. I guess anything that links through the top bar.
| @@ -21,6 +21,7 @@ | |||
| {% else %} | |||
| {% set rowIndex = properties.filter_offset|default(0) + 1 %} | |||
| {%- for rowId, row in dataTable.getRows() -%} | |||
| {% if rowId != constant('Piwik\\DataTable::ID_TOTALS_ROW') %} | |||
There was a problem hiding this comment.
@diosmosis just double checking... in my Datatable class in your branch I'm not seeing that constant.
There was a problem hiding this comment.
I think you're looking at old code, it's not there if I look at "files changed".
* Fix label truncation calculation regrssion of #14365 * updates expected screenshots
* Fix label truncation calculation regrssion of #14365 * updates expected screenshots
Fixes #5711
Fixes #7716
Related sparkline PR is here: davaxi/Sparkline@master...matomo-org:multiple-series