Skip to content

Adds missing / in directoy check #14228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Adds missing / in directoy check #14228

merged 1 commit into from
Mar 20, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 19, 2019

fixes #14226

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 19, 2019
@sgiehl sgiehl added this to the 3.10.0 milestone Mar 19, 2019
@Findus23
Copy link
Collaborator

Any reason why the PHP error/warning hasn't occurred in the tests?

@sgiehl
Copy link
Member Author

sgiehl commented Mar 19, 2019

if no open_basedir restriction is active the is_dir simply returns false

tsteur
tsteur reviewed Mar 19, 2019
View reviewed changes
@sgiehl sgiehl merged commit b5d2fc6 into 3.x-dev Mar 20, 2019
@sgiehl sgiehl deleted the dirfix branch March 20, 2019 09:39
@sgiehl sgiehl modified the milestones: 3.10.0, 3.9.1 Mar 20, 2019
@mickaelmonsieur
Copy link

and does not need to publish an immediate fix or remove the current version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

open_basedir restriction AND Support multiple plugin paths
4 participants
@sgiehl @Findus23 @mickaelmonsieur @tsteur