Skip to content

Fix dashboard copy to user with special chars #14197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2019
Merged

Fix dashboard copy to user with special chars #14197

merged 2 commits into from
Mar 28, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 13, 2019

encoding the user name in the request causes problems as soon as any special chars are included because they won't be decoded on server side.

fixes #14191

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 13, 2019
@sgiehl sgiehl added this to the 3.10.0 milestone Mar 15, 2019
@mattab mattab modified the milestones: 3.11.0, 3.10.0 Mar 19, 2019
@sgiehl sgiehl merged commit 6aedd2a into 3.x-dev Mar 28, 2019
@sgiehl sgiehl deleted the fixdashboardcopy branch March 28, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Copy dashboard doesn't work with special characters in the username
3 participants
@sgiehl @diosmosis @mattab