-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Indent actions belonging to a pageview #14063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@diosmosis I've merged in the latest 3.x-dev changes. But it seems it's currently broken. Always seeing the error |
@sgiehl added the missing file. |
@diosmosis Seems the visitor profile is broken now. Getting this error when opening one:
|
…e border so it looks like it correctly ends.
@sgiehl updated to work in visitor profile. not sure if the implementation is the best or not, let me know if you see room for improvement. |
@tsteur The css class used is determined by the plugin due to how the template is defined, so better in the plugin i'd say. |
@diosmosis OK I will check to see how to maybe detect the Matomo version and then change the colour of the icon depending on the version cause for older installations we still want to show the black color |
I assume you did a hard reload? I've seen this issue, but should have been working... same for the show more link for 7 actions. Then again, maybe the selector is using the core
If there's no pageview ID set for the action (or the wrong pageview ID is set), then it won't be grouped. Are you looking at the demo data? pageview IDs aren't always set correctly there. |
@diosmosis could we add |
Yes looks good 👍 |
Created iconSvg issue here: #14198 |
I suppose we could merge it now and make further changes if needed after using it for a while @mattab @diosmosis ? |
👍 |
This will have to change when the visitor timeline is put in.
Fixes #13136
Fixes #12894