Skip to content

Fix segment for referrer websites subtables #14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fix segment for referrer websites subtables #14933

merged 1 commit into from
Oct 4, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 1, 2019

fixes #14918

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 1, 2019
@sgiehl sgiehl added this to the 3.12.0 milestone Oct 1, 2019
@tsteur
Copy link
Member

tsteur commented Oct 2, 2019

@sgiehl LGTM. Could you fix the tests though before merging?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 2, 2019

@tsteur actually it seems that none of the failing tests is related to this changes...

@tsteur
Copy link
Member

tsteur commented Oct 2, 2019

What about eg https://travis-ci.org/matomo-org/matomo/jobs/592247565#L821 ?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 2, 2019

Interesting. Those tests didn't fail for the push build, but in pr build 🤷‍♂️
Will update it

@sgiehl sgiehl force-pushed the referrersegmentfix branch from efb85e0 to 69cda4d Compare October 2, 2019 21:46
@tsteur
Copy link
Member

tsteur commented Oct 3, 2019

@sgiehl there still seem to be some failing tests see https://travis-ci.org/matomo-org/matomo/jobs/592791003#L821

@sgiehl sgiehl force-pushed the referrersegmentfix branch from 69cda4d to 35cbd70 Compare October 3, 2019 07:46
@sgiehl sgiehl force-pushed the referrersegmentfix branch from 35cbd70 to e294ba9 Compare October 3, 2019 19:25
@tsteur tsteur merged commit 07e84fd into 3.x-dev Oct 4, 2019
@tsteur tsteur deleted the referrersegmentfix branch October 4, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Segmented Visitor log on Acquisition > Websites sub-table does not open the right visits
2 participants
@sgiehl @tsteur