Skip to content

Soft delete segments #14846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

Soft delete segments #14846

merged 2 commits into from
Sep 3, 2019

Conversation

katebutler
Copy link

Fixes #14826

@katebutler katebutler added the Needs Review PRs that need a code review label Sep 3, 2019
@katebutler katebutler added this to the 3.12.0 milestone Sep 3, 2019
@tsteur
Copy link
Member

tsteur commented Sep 3, 2019

👍

@tsteur tsteur merged commit ea18198 into 3.x-dev Sep 3, 2019
@tsteur tsteur deleted the 14826 branch September 3, 2019 02:03
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

When deleting a segment, do a soft delete instead of a hard delete
3 participants
@katebutler @tsteur @mattab