Skip to content

Ignore variables that start w/ @ when auto-detecting tables in segment sql expressions. #14425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2019
Merged

Ignore variables that start w/ @ when auto-detecting tables in segment sql expressions. #14425

merged 4 commits into from
May 16, 2019

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 7, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone May 7, 2019
@tsteur
Copy link
Member

tsteur commented May 8, 2019

Can you add some tests for this @diosmosis ?

@diosmosis
Copy link
Member Author

will do

@diosmosis
Copy link
Member Author

@tsteur Updated

@diosmosis diosmosis merged commit ed823e9 into 3.x-dev May 16, 2019
@diosmosis diosmosis deleted the segment-table-session branch May 16, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@diosmosis @tsteur