Remember user who created a site. #13362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Aug 29, 2018
core/Db/Schema/Mysql.php
Outdated
| @@ -75,6 +75,7 @@ public function getTablesCreateSql() | |||
| `group` VARCHAR(250) NOT NULL, | |||
| `type` VARCHAR(255) NOT NULL, | |||
| keep_url_fragment TINYINT NOT NULL DEFAULT 0, | |||
| user_created VARCHAR(100) NULL, | |||
There was a problem hiding this comment.
would it be login_created or user_login_created or login_creator or something? In the user table it is the login column that matches it. Might be more clear? not sure...
There was a problem hiding this comment.
Can change it to creator_login as in "the creator's login"? Was trying to be consistent w/ the ts_created column w/ user_created.
There was a problem hiding this comment.
creator_login 👍 I was actually just thinking before the same. otherwise sounds like a user was created
|
Updated. |
tsteur
reviewed
Sep 7, 2018
core/Site.php
Outdated
| * @param int $idsite The site ID. | ||
| * @return string|null If null, the site was created before the creation user was tracked. | ||
| */ | ||
| public static function getCreationUserFor($idsite) |
There was a problem hiding this comment.
Maybe getCreatorLoginFor? For consistency be also good to add a public function getCreatorLogin
2c484b6 to
35837ab
Compare
|
I presume tests need to be fixed but otherwise looks good to merge. |
diosmosis
added a commit
that referenced
this pull request
Sep 20, 2018
* Remember user who created a site. * Bump version & change column name to creator_login. * Rename Site::getCreationUserFor * Process sites like other methods in getPatternMatchSites(). * Update expected test files. * update test again
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Remember user who created a site. * Bump version & change column name to creator_login. * Rename Site::getCreationUserFor * Process sites like other methods in getPatternMatchSites(). * Update expected test files. * update test again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.