Skip to content

Show confirm before changing a users password and show notification on save complete. #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 23, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 23, 2018
@mattab
Copy link
Member

mattab commented Aug 28, 2018

The popup is displayed also when the password field is left empty, although then the password isn't changed. Let's hide popover when the field is left blank?

@mattab mattab modified the milestones: 3.6.0, 3.7.0 Aug 28, 2018
@diosmosis
Copy link
Member Author

Updated

@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018
@mattab mattab merged commit 7900b65 into 3.x-dev Sep 1, 2018
@mattab mattab deleted the users-manager-tweaks branch September 1, 2018 23:02
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…n save complete. (matomo-org#13342)

* Show confirm before changing a users password and show notification on save complete.

* Do not show password confirm is password input is blank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants