Make sure simple datatable metadata is serialized + some test case changes #13296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Aug 15, 2018
core/DataTable.php
Outdated
| @@ -308,7 +308,7 @@ class DataTable implements DataTableInterface, \IteratorAggregate, \ArrayAccess | |||
| * | |||
| * @var array | |||
| */ | |||
| private $metadata = array(); | |||
| protected $metadata = array(); | |||
There was a problem hiding this comment.
Could you maybe add a comment so nobody will set it to private later "by accident"? Be good to also have a system test for this (if possible)
There was a problem hiding this comment.
should be doable to have a test
|
@tsteur added test and docs |
ced268a to
61f9007
Compare
61f9007 to
07287f2
Compare
tsteur
approved these changes
Aug 21, 2018
diosmosis
added a commit
that referenced
this pull request
Sep 20, 2018
…anges (#13296) * Make DataTable metadata protected so it will be serialized in derived classes. * Allow SystemTestCase::runAnyApiTest to test any format and use a testSuffix. * Add test for metadata serialization & note about it in field docs.
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…anges (matomo-org#13296) * Make DataTable metadata protected so it will be serialized in derived classes. * Allow SystemTestCase::runAnyApiTest to test any format and use a testSuffix. * Add test for metadata serialization & note about it in field docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: