Fix too much whitespace in title #13197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In login screen, the title may contain too much whitespace.
sgiehl
reviewed
Jul 23, 2018
| @@ -4,11 +4,7 @@ | |||
| {% block head %} | |||
| <meta charset="utf-8"> | |||
| <title> | |||
| {%- block pageTitle -%} | |||
| {%- if title is defined %}{{ title }} - {% endif %} | |||
| {%- if categoryTitle is defined %}{{ categoryTitle }} - {% endif %} | |||
There was a problem hiding this comment.
Actually adding a - to the closing endif should do the same:
{% endif -%}
|
@sgiehl changed it |
sgiehl
approved these changes
Jul 23, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Fix too much whitespace in title In login screen, the title may contain too much whitespace. * Update layout.twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In login screen, the title may contain too much whitespace and as a result the title may not be fully visible. see
