Skip to content

Exclude non core plugins from translation percentage calculation #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

Exclude non core plugins from translation percentage calculation #13981

merged 1 commit into from
Jan 21, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 20, 2019 •
edited
Loading

Note: This will also exclude our Marketplace plugins that are not bundled with core.

@sgiehl sgiehl added the c: Website matomo.org For issues related to our matomo.org website. label Jan 20, 2019
diosmosis
diosmosis approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@sgiehl sgiehl added this to the 3.8.0 milestone Jan 21, 2019
@mattab mattab modified the milestones: 3.8.0, 3.9.0 Jan 21, 2019
@diosmosis diosmosis merged commit f60c92a into 3.x-dev Jan 21, 2019
@diosmosis diosmosis deleted the translationpercentage branch January 21, 2019 23:41
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
c: Website matomo.org For issues related to our matomo.org website.
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiehl @diosmosis @mattab