Skip to content

Changed wording of YouAreOptedIn #13538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2018
Merged

Changed wording of YouAreOptedIn #13538

merged 2 commits into from
Oct 10, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 4, 2018

fix #12954

replaces #13187
kudos to @electric-paper

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 4, 2018
@tsteur tsteur mentioned this pull request Oct 4, 2018
Closed
diosmosis
diosmosis reviewed Oct 4, 2018
View reviewed changes
plugins/CoreAdminHome/lang/en.json Outdated
"YouAreOptedOut": "You are currently opted out.",
"YouAreNotOptedOut": "You are currently not opted out.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just say "You are not opted out."?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will update

diosmosis
diosmosis approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots will probably need an update.

@mattab mattab added this to the 3.6.1 milestone Oct 9, 2018
@tsteur tsteur merged commit c2085ae into 3.x-dev Oct 10, 2018
@tsteur tsteur deleted the 13187 branch October 10, 2018 03:40
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Changed wording of YouAreOptedIn (matomo-org#13538)
6ec6e7b 
* Changed wording of YouAreOptedIn

* Update en.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Please change wording of "You are currently opted in."
3 participants
@tsteur @diosmosis @mattab