Skip to content

Limit password length #13494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2018
Merged

Limit password length #13494

merged 1 commit into from
Nov 1, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 28, 2018

fix #13491

@tsteur tsteur added this to the 3.7.0 milestone Sep 28, 2018
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 28, 2018
sgiehl
sgiehl approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgiehl sgiehl merged commit 5aed978 into 3.x-dev Nov 1, 2018
@sgiehl sgiehl deleted the 13491 branch November 1, 2018 12:51
@pixelverbieger
Copy link

pixelverbieger commented Nov 19, 2018 •
edited
Loading

"ExceptionInvalidPasswordTooLong": "The password length must be less than %1$s characters.",

That's not 100% exact.
The passwort doesn't have to be less than 200 characters (which would be a maximum of 199), but "The password length must not be longer than %1$s characters."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Limit password length (at a reasonable length)
3 participants
@tsteur @pixelverbieger @sgiehl