Fixes Ecommerce overview #13405
Merged
Fixes Ecommerce overview #13405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Sep 10, 2018
plugins/Ecommerce/Controller.php
Outdated
| @@ -76,11 +76,21 @@ public function getConversionsOverview() | |||
| { | |||
| $view = new View('@Ecommerce/conversionOverview'); | |||
| $idGoal = Common::getRequestVar('idGoal', null, 'string'); | |||
|
|
|||
| $goalMetrics = Request::processRequest('Goals.get', array('idGoal' => $idGoal, 'filter_limit' => '-1'), $default = []); | |||
| $idSite = Common::getRequestVar('idSite', null, 'int'); | |||
There was a problem hiding this comment.
here we could probably use $this->idSite but not needed. Should be all good to merge!
|
Whoops, was fixing the build and fixed this directly in 3.x-dev, will merge this shortly |
diosmosis
pushed a commit
that referenced
this pull request
Sep 20, 2018
* Pass correct parameters to API call * use idSite property
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Pass correct parameters to API call * use idSite property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ecommerce overview broke with the merge of #13293.
The parameters send to the API method were incomplete. See