update piwik-icons submodule #12389
Merged
update piwik-icons submodule #12389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's failing often in the last days... maybe we need to increase the wait times. will check that when I have some time |
|
Now all (working) tests should be fixed |
|
Not sure why some of the tests nearly always fail for the build on branches, but work for PR builds against master... You can update the one remaining here: https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/25440/Live_visitor_log.png |
|
Done in a95699e |
|
Will have another look as soon as the builds finished. Guess we can merge it then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was in the middle of a restructure, the last Piwik release didn't include an update of the icons.
Because it's finished now Piwik 3.3 will have many icon changes (289 files in 37 commits):
matomo-org/matomo-icons@ac9c01d...48d5d33
Thanks again to @sogen for also contributing icons.