Show shortcut help screen when pressing ?
#12283
Conversation
|
I reckon making this extensible for plugins will be a different issue right? Could otherwise maybe just post an event with an array like |
|
Would be good to make the Help popup already extensible if possible. Otherwise, nice new feature 👍 |
|
As such shortcuts will always be added in JavaScript I'll try to move some logic there... |
|
👍 |
|
I've now implemented a new method |
CHANGELOG.md
Outdated
| @@ -25,6 +25,7 @@ The Product Changelog at **[piwik.org/changelog](https://piwik.org/changelog)** | |||
|
|
|||
| ### New Features | |||
| * New config.ini.php setting `show_update_notification_to_superusers_only` makes it possible to hide update notifications for all users except of superusers | |||
| * New JavaScript method `piwikHelper.registerShortcut` allows plugins to bind keyboard shortcuts. A summary for available shortcuts will be shown by pressing `?` | |||
There was a problem hiding this comment.
Let's move this mention into the 3.2.1 changelog section
| @@ -174,7 +174,7 @@ protected static function cleanupHostAndHashTag($parsedUrl, $idSite = false) | |||
| } | |||
|
|
|||
| if (!empty($parsedUrl['host'])) { | |||
| $parsedUrl['host'] = Common::mb_strtolower($parsedUrl['host'], 'UTF-8'); | |||
| $parsedUrl['host'] = Common::mb_strtolower($parsedUrl['host']); | |||
There was a problem hiding this comment.
This change is un-related and not for this PR?
There was a problem hiding this comment.
Yes. Unrelated. It removes an useless parameter as Common::mb_strtolower only takes one parameter
|
LGTM. @tsteur could you maybe check & merge this one? |
|
Rebased branch and resolved conflicts... @tsteur any additional change requests? |
fixes #5230