Skip to content

Hide widgets not working without internet connection if disabled in config #12279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 22, 2018
Merged

Hide widgets not working without internet connection if disabled in config #12279

merged 5 commits into from
Mar 22, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 15, 2017 •
edited
Loading

Hide widgets when enable_internet_features = 0 is set in config:

  • SEO > SEO rankings
  • About Piwik > Piwik Changelog
  • About Piwik > Piwik.org Blog
  • About Piwik > Latest Marketplace Updates
  • About Piwik > Premium Features

refs #6324

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels Nov 15, 2017
@mattab mattab added this to the 3.2.2 milestone Nov 22, 2017
@mattab
Copy link
Member

mattab commented Dec 15, 2017

We'd also need to hide the

  • Premium features widget
  • Latest Marketplace Updates widget
  • let's also test most screens in Admin, without internet, to check the feature really works, there are maybe a few remaining things to disable

@sgiehl sgiehl force-pushed the seowidgetnointernet branch from b145fed to 8aeca2d Compare December 15, 2017 08:06
@sgiehl
Copy link
Member Author

sgiehl commented Dec 15, 2017

@mattab The two mentioned widgets are now removed as well. Everything else shouldn't be handled in this PR. It's only one step towards solving #6324. It's better to keep pull requests simple and small, so they can be easily merged. So maybe add your other comment in that issue.

@sgiehl sgiehl force-pushed the seowidgetnointernet branch from 8aeca2d to e4e1dce Compare December 19, 2017 20:48
@sgiehl sgiehl force-pushed the seowidgetnointernet branch from e4e1dce to 79d90aa Compare January 6, 2018 15:09
@sgiehl sgiehl force-pushed the seowidgetnointernet branch from 79d90aa to 019cbb8 Compare January 23, 2018 09:04
@sgiehl sgiehl force-pushed the seowidgetnointernet branch 2 times, most recently from cc87181 to 6c3dda3 Compare March 11, 2018 21:55
@mattab mattab modified the milestones: 3.4.0, 3.3.1 Mar 19, 2018
@diosmosis
Copy link
Member

Would it be possible to use consts for the widget categories/names? If the names change, these new changes might break.

@mattab mattab modified the milestones: 3.4.0, 3.4.1 Mar 22, 2018
@sgiehl sgiehl force-pushed the seowidgetnointernet branch from 6c3dda3 to 6f18f37 Compare March 22, 2018 20:44
@sgiehl
Copy link
Member Author

sgiehl commented Mar 22, 2018

I've updated the PR so it better handles possible name changes of the widgets

@diosmosis
Copy link
Member

@mattab PR looks good, the UI test failures seem unrelated.

@mattab mattab merged commit c61018b into 3.x-dev Mar 22, 2018
@mattab mattab deleted the seowidgetnointernet branch March 22, 2018 23:51
@mattab mattab modified the milestones: 3.4.1, 3.4.0 Mar 22, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Hide widgets not working without internet connection if disabled in c…
741cd3d 
…onfig (matomo-org#12279)

* Hide SEO rankings widget if internet is disabled in config

* Hide RSS widgets if internet is disabled in config

* Remove more wirdgets when internet connection disabled

* Adjust widgets to remove after rename to Matomo

* Code improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiehl @mattab @diosmosis