Skip to content

Fixes seriespicker regression (changes to dashboard weren't saved anymore) #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fixes seriespicker regression (changes to dashboard weren't saved anymore) #12223

merged 1 commit into from
Oct 25, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 24, 2017

changes to dashboard weren't saved anymore when changing series selection

regression from #11905

@sgiehl
Fixes seriespicker regression:
a907a21 
changes to dashboard weren't saved anymore when changing series selection
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Oct 24, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Oct 24, 2017
@sgiehl sgiehl requested a review from diosmosis October 24, 2017 19:34
diosmosis
diosmosis approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the regression. (I'm approving, but not sure if someone else should review or not. Though this looks simple enough.)

@sgiehl sgiehl merged commit 5912d91 into 3.x-dev Oct 25, 2017
@sgiehl sgiehl deleted the seriespickerregression branch October 25, 2017 19:34
@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017
@mattab mattab changed the title Fixes seriespicker regression Fixes seriespicker regression (changes to dashboard weren't saved anymore ) Dec 5, 2017
@mattab mattab changed the title Fixes seriespicker regression (changes to dashboard weren't saved anymore ) Fixes seriespicker regression (changes to dashboard weren't saved anymore) Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @diosmosis