Skip to content

Ensure segment param is always considered for widget urls #12177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2017
Merged

Ensure segment param is always considered for widget urls #12177

merged 2 commits into from
Oct 19, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 12, 2017

fixes #12172

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 12, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Oct 12, 2017
@sgiehl sgiehl force-pushed the widgetizedsegment branch 2 times, most recently from 8ae711a to 97348b2 Compare October 12, 2017 20:24
@sgiehl sgiehl force-pushed the widgetizedsegment branch from 97348b2 to 9586987 Compare October 13, 2017 09:09
@mattab mattab merged commit 7921d02 into 3.x-dev Oct 19, 2017
@mattab
Copy link
Member

mattab commented Oct 19, 2017

Works 👍

@mattab mattab deleted the widgetizedsegment branch October 19, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

When embedding dashboard in an iframe, some widgets don't apply the selected Segment
2 participants
@sgiehl @mattab