Skip to content

Make dashboard links working for all browsers #12176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2017
Merged

Make dashboard links working for all browsers #12176

merged 1 commit into from
Oct 17, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 12, 2017

fixes #12113

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 12, 2017
@sgiehl sgiehl added this to the 3.2.1 milestone Oct 12, 2017
@mattab
Copy link
Member

mattab commented Oct 17, 2017

IIRC this issue has happened before.

  • Could you add UI test to check this particular behavior?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 17, 2017 via email

@mattab
Copy link
Member

mattab commented Oct 17, 2017

ok 👍

@mattab
Copy link
Member

mattab commented Oct 17, 2017

Works!

@mattab mattab merged commit 0124f45 into 3.x-dev Oct 17, 2017
@mattab mattab deleted the fixdashboardlinks branch December 5, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

issue with Widgetized dashboards: only [object Object] displayed
2 participants
@sgiehl @mattab