Skip to content

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 14, 2018

added a note that most keywords will be reported as unknown as they are hidden by search engines

added a note that most keywords will be reported as unknown as they are hidden by search engines
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 14, 2018
@sgiehl sgiehl added this to the 3.5.1 milestone May 14, 2018
@diosmosis
Copy link
Member

Looks good. Think it would be better to add an extra <br/> in the first translate call, though, otherwise it looks inconsistent to me. Eg this w/ the extra <br/>,

image

vs w/o it:

image

Can add it myself if it's ok w/ you, otherwise don't want to change your PR w/o permission :)

Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one optional comment

@sgiehl
Copy link
Member Author

sgiehl commented May 18, 2018

@diosmosis I'm fine with adding an additional <br />

@sgiehl sgiehl merged commit 682cc40 into 3.x-dev May 20, 2018
@sgiehl sgiehl deleted the improvereportdoc branch May 20, 2018 16:39
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
)

* Improve report documentation of search keywords report

added a note that most keywords will be reported as unknown as they are hidden by search engines

* adds extra line break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants