Skip to content

Remove usage of synchronous ajax requests in the codebase #12546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 14, 2018
Merged

Remove usage of synchronous ajax requests in the codebase #12546

merged 7 commits into from
Jun 14, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 10, 2018

Removes all usages of synchronous ajax requests and adds a deprecation note for it.

With #11756 the possibility for synchronous ajax will be removed in Matomo 4 finaly.

refs #8246

@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 10, 2018
@sgiehl sgiehl added this to the 3.3.1 milestone Feb 10, 2018
@sgiehl sgiehl requested a review from tsteur February 10, 2018 22:01
@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2018

Note: Will try to fix the UI tests soon. Seems they are failing as no synchronous request is blocking. Maybe need to add some more wait times

@sgiehl sgiehl force-pushed the donotusesyncajax branch 6 times, most recently from 472a773 to 139ea93 Compare February 13, 2018 21:00
@sgiehl sgiehl force-pushed the donotusesyncajax branch 3 times, most recently from 35560bb to 189df4c Compare March 11, 2018 21:54
@mattab mattab modified the milestones: 3.4.0, 3.4.1 Mar 21, 2018
@sgiehl sgiehl force-pushed the donotusesyncajax branch from 189df4c to 7de3ec2 Compare March 25, 2018 13:51
tsteur
tsteur requested changes Mar 28, 2018
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@sgiehl sgiehl force-pushed the donotusesyncajax branch 2 times, most recently from fd91620 to f83c2d2 Compare April 1, 2018 16:38
@mattab mattab modified the milestones: 3.5.0, 3.6.0 Apr 12, 2018
@sgiehl sgiehl force-pushed the donotusesyncajax branch from f83c2d2 to 1004cb7 Compare May 31, 2018 20:29
@diosmosis diosmosis merged commit 6a0c960 into 3.x-dev Jun 14, 2018
@diosmosis diosmosis deleted the donotusesyncajax branch June 14, 2018 02:36
@sgiehl sgiehl mentioned this pull request Aug 28, 2018
Merged
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Remove usage of synchronous ajax requests (matomo-org#12546)
9ae202d 
* Do not use sync ajax requests

* adds deprecation comments

* convert some methods to be fully async

* adds minimum waittime after page load in ui tests

* improve wait times
@sgiehl sgiehl mentioned this pull request Dec 9, 2019
Closed
@sgiehl sgiehl mentioned this pull request Feb 3, 2020
Closed
@mattab mattab changed the title Remove usage of synchronous ajax requests Remove usage of synchronous ajax requests in the codebase Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sgiehl @tsteur @diosmosis @mattab