Make LogAggregator::getWhereStatement public #10954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `generateQuery()` in to archive reports it will automatically bind parameters from `getGeneralQueryBindParams()`. This works only when also applying the matching where statement that is generated by `getWhereStatement()`. Therefore the method needs to be public, otherwise `generateQuery()` is not really useful and may invalidate many plugins over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
generateQuery()in to archive reports it will automatically bind parameters fromgetGeneralQueryBindParams(). This works only when also applying the matching where statement that is generated bygetWhereStatement(). Therefore the method needs to be public, otherwisegenerateQuery()is not really useful and may invalidate many plugins over time.