[Bug] Possible Race condition when removing last site might break instance #23222
Description
What happened?
Matomo aims to ensure that at least one website is existent.
However if there are two websites and a removal request for both websites is sent at the exact same time it can happen that the check, to prevent the removal of the last site, isn't triggered and both sites get removed.
The instance is broken afterwards if no website remains.
What should happen?
Removing websites should be handled concurrency-safe.
How can this be reproduced?
- Go to Manage Measurables (a.k.a. Website Management).
- Add one more website, so now you have 2 websites listed.
- Send API requests to remove both websites in parallel
Matomo version
any
PHP version
No response
Server operating system
No response
What browsers are you seeing the problem on?
No response
Computer operating system
No response
Relevant log output
Validations
- Read our Contributing Guidelines.
- Follow our Security Policy.
- Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
- The provided steps to reproduce is a minimal reproducible of the Bug.