-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
EnhancementFor new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Description
Various methods the core/Db
and core/DbHelper
helper classes execute MySQL specific statements. In order to support alternative databases these statements should be moved to new methods defined in core/Db/AdapterInterface
and implemented by the chosen PDO Adapter.
Suggested Approach
- Review all methods in
core/Db
andcore/DbHelper
, identify those which are very specific to MySQL. - Create new methods in
core/Db/AdapterInterface
. - Implement the methods in the Matomo standard MySQL PDO driver
core/Db/Adapter/Pdo/Mysql
. - Rework the
core/Db
andcore/DbHelper
method to call the new methods on the PDO adapter. - This should not in any way change behavior for MySQL.
An example of a MySQL specific helper function is DbHelper::getDefaultCharset())
which fails on TiDB, SingleStore and likely other databases.
Metadata
Metadata
Assignees
Labels
EnhancementFor new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.