Dashboard broken by 4.9.0 browser incompatibility #19109
Description
Expected Behavior
Expected to be able to use the Matomo dashboard normally in Firefox version 67 after updating to Matomo 4.9.0.
Current Behavior
Blue header on dashboard displays normally, but page is otherwise blank. All links in the header have same broken behaviour, displaying header but nothing else, except that on the configuration page, the sidebar ("personal/system/privacy/etc.") displays in addition to the header.
Browser console displays these error messages:
TypeError: translation.replaceAll is not a function
[index.php:780:361](https://files.northcoastsynthesis.com/piwik/index.php?module=Proxy&action=getCoreJs&cb=12746d9156d9358740bc57d731cb3e82)
Error: [$injector:nomod] http://errors.angularjs.org/1.8.2/$injector/nomod?p0=piwikApp.service [index.php:97:168](https://files.northcoastsynthesis.com/piwik/index.php?module=Proxy&action=getCoreJs&cb=12746d9156d9358740bc57d731cb3e82)
TypeError: r is undefined
[index.php:3:11313](https://files.northcoastsynthesis.com/piwik/index.php?module=Proxy&action=getUmdJs&chunk=1&cb=12746d9156d9358740bc57d731cb3e82)
TypeError: o is undefined
[index.php:3:15305](https://files.northcoastsynthesis.com/piwik/index.php?module=Proxy&action=getUmdJs&chunk=2&cb=12746d9156d9358740bc57d731cb3e82)
Error: [$injector:modulerr] http://errors.angularjs.org/1.8.2/$injector/modulerr?p0=piwikApp&p1=%5B%24injector%3Anomod%5D%20http%3A%2F%2Ferrors.angularjs.org%2F1.8.2%2F%24injector%2Fnomod%3Fp0%3DpiwikApp%0AF%2F%3C%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A97%3A168%0AMe%2F%3C%2F%3C%2F%3C%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A116%3A503%0Ab%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A116%3A25%0AMe%2F%3C%2F%3C%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A116%3A277%0Ag%2F%3C%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A133%3A201%0Ar%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A98%3A76%0Ag%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A133%3A49%0Afb%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A137%3A153%0Ac%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A112%3A57%0AWc%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A112%3A370%0AEe%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A111%3A45%0A%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A441%3A117%0Ai%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A4%3A27151%0AfireWith%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A4%3A27914%0Aready%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A4%3A29707%0AJ%40https%3A%2F%2Ffiles.northcoastsynthesis.com%2Fpiwik%2Findex.php%3Fmodule%3DProxy%26action%3DgetCoreJs%26cb%3D12746d9156d9358740bc57d731cb3e82%3A4%3A29892%0A [index.php:97:168](https://files.northcoastsynthesis.com/piwik/index.php?module=Proxy&action=getCoreJs&cb=12746d9156d9358740bc57d731cb3e82)
Possible Solution
Remove the call to replaceAll that was introduced to source file "plugins/Morpheus/javascripts/piwikHelper.js" by commit afbe9c2 . Reverting that commit on my local copy, and removing the cached file "tmp/assets/asset_manager_core_js.js" which seems to be generated from that one, seems to fix the problem with no obvious downside. Presumably, whatever this commit was intended to solve will remain unsolved without the call to replaceAll. Some other way of replacing the percent signs (possibly just "replace") might be appropriate.
Add an automated test to make sure future versions will not be released containing calls to replaceAll.
Add a policy of human testing with an older browser on release candidates before releasing them.
Add a policy that a browser-breaking change will not be made without both warning users of the change and providing a path to opt out of the change.
Steps to Reproduce (for Bugs)
- Attempt to use Matomo dashboard in a browser that does not support replaceAll, such as Firefox 67.
Context
This bug makes the Matomo dashboard/admin interface impossible for me to use at all. Independently of the technical issue, the fact that this occurred without warning on a routine update, creating emergency downtime for my business, reduces my trust in Matomo and my likelihood of buying any further services from the Matomo organization in the future.
Your Environment
- Matomo Version: 4.9.0
- PHP Version: 7.4.20
- Server Operating System: Linux
- Additionally installed plugins:
- Browser: Firefox 67
- Operating System: Linux