Skip to content

Making it easier to know when a code review is required #17317

@tsteur

Description

@tsteur

Hi everyone, currently it's not always clear which pull requests needs another review. Especially when there are several iterations of changes during a review.

Currently, once a pull request is ready for a review we assign the label Needs Review. Then someone reviews it and the issue stays in Needs Review until merged. This makes it hard to know when the issue needs yet another review. You often have to click into the same issue several times to check if there's an update and if it actually does need another review or if we are waiting for the author to make changes.

I propose that once an issue has been reviewed, we remove the Needs Review label, and maybe add some other label like WIP work in progress or Changes Requested or change it to draft or simply don't add another label. Then, once the PR author made the required changes the label Needs Review would be added again.

I think this would make it more clear which reviews actually need our attention currently since reviews have pretty much highest priority for us.

Any thoughts or ideas @diosmosis @Findus23 @flamisz @sgiehl @mattab ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Better processesIndicates an issue is about improving how we work.RFCIndicates the issue is a request for comments where the author is looking for feedback.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions