Skip to content

Reexpire archive lock less often #15870

@tsteur

Description

@tsteur

There was #15749 and #15747

But I think it might not fully work actually. In performance insights still seeing these queries executed quote often and taking quite some resources. It seems like might be because in getDb() https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/LogAggregator.php#L1188 we always create a new instance of ArchivingDbAdapter and therefore https://github.com/matomo-org/matomo/blob/3.13.5-rc1/core/DataAccess/ArchivingDbAdapter.php#L37 would be quite often null.

BTW should maybe change the default value to 0 so it's not null + $timeBetweenReexpires in reexpireLock().

Maybe would somehow need to remember the last time per archiving lock?

fyi @diosmosis

Metadata

Metadata

Assignees

Labels

c: PerformanceFor when we could improve the performance / speed of Matomo.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions