Skip to content

disableHeartBeatTimer doesn't really removes event listeners #14586

@IIIEII

Description

@IIIEII

In piwik.js:
setUpHeartBeat() attaches to 'focus' and 'blur' window events without capture:

addEventListener(windowAlias, 'focus', heartBeatOnFocus);
addEventListener(windowAlias, 'blur', heartBeatOnBlur);

But disableHeartBeatTimer() removes those events with capture (third parameter):

windowAlias.removeEventListener('focus', heartBeatOnFocus, true);
windowAlias.removeEventListener('blur', heartBeatOnBlur, true);

So event listeners are not really removed and script continue to send ping requests.

Metadata

Metadata

Assignees

Labels

BugFor errors / faults / flaws / inconsistencies etc.Help wantedBeginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions