Make Matomo PHP 7.3 compatible #13418
Description
In 3 months PHP 7.3 will be released, so let's start making Matomo compatible!
I tried setting up a new Matomo instance using PHP 7.3 RC2 (so all bugs found now will probably also be in the final release) and most things are working fine. These errors occurred:
ErrorException: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior
#17 vendor/tedivm/jshrink/src/JShrink/Minifier.php(196): handleError
Stack Trace
from https://github.com/tedious/JShrink
- fixed
2018/09/12 20:46:17 [error] 8919#8919: *137700 FastCGI sent in stderr:
"PHP message: PHP Warning:
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
in /var/www/matomo-beta/vendor/tedivm/jshrink/src/JShrink/Minifier.php on line 243"
also from https://github.com/tedious/JShrink
- fixed
WARNING [2018-09-12 19:04:26] 20837 /var/www/matomo-beta/plugins/LanguagesManager/Commands/CreatePull.php(217): Warning - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? - Matomo 3.6.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)
matomo/plugins/LanguagesManager/Commands/CreatePull.php
Lines 214 to 217 in b8e4d27
ErrorException: compact(): Undefined variable: idGoal
#15 plugins/API/API.php(401): handleError
ErrorException: Undefined index: never
#15 core/View/HtmlReportEmailHeaderView.php(41): handleError
#14 core/View/HtmlReportEmailHeaderView.php(41): __construct
#13 core/ReportRenderer/Html.php(84): renderFrontPage
- moved to Undefined index: never #13638
To be continued...
If you want to, I can create test-admin accounts on the php 7.3 instance.