-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
BugFor errors / faults / flaws / inconsistencies etc.For errors / faults / flaws / inconsistencies etc.Help wantedBeginner friendly issues or issues where we'd highly appreciate community's help and involvement.Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Description
IP::getNonProxyIpFromHeader
attempts to retrieve the client IP address from headers configured in proxy_client_headers[]
. This calls IP::getLastIpFromList
, excluding proxies configured via proxy_ips[]
.
What I do not understand is why by default this returns the last IP, whereas the format for X-Forwarded-For
is client, proxy1, proxy2, ...
:
http://en.wikipedia.org/wiki/X-Forwarded-For#Format
This only becomes an issue when running Piwik behind multiple proxies; for example the configuration in question is:
[Enterprise Appliance] => [IIS ARR] => [Piwik]
So Piwik sees:
X-Forwarded-For: <client>, <enterprise_appliance>
Basically the current behavior would seem to select the IP of the last proxy by default. This would be problematic in a scenario with variable proxy IPs.
Metadata
Metadata
Assignees
Labels
BugFor errors / faults / flaws / inconsistencies etc.For errors / faults / flaws / inconsistencies etc.Help wantedBeginner friendly issues or issues where we'd highly appreciate community's help and involvement.Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.