-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closed
Labels
MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Description
This is the email kickstart of the new AngularJS adventure! We'll do our best to make the most out of AngularJS & work as a team to make this a positive change. Thomas will get started on Benaka's suggestion.
Goal: integrate the website selector widget as an example of how to best use AngularJS.
It should have the following requirements:
- the selector should be in a self-contained class/widget/whatever
- the selector should be re-usable; specifically it should be possible to place it in another template and place two or more in one page (the selector is used in a couple places, so there'll be ways to test this)
- the selector should be customizable
- the selector should be documented and it should be possible (at least conceptually) to expose this documentation to plugin developers
- ensure the selector's resources are cleaned up properly on page change, widget reload, etc.
- Untrusted input should be escaped but not by Piwik itself (for example w/ jquery:
$('<span/>').text(site.name); instead of $ ('<span>' + site.name + '</span>');). - it should be possible to create another class/widget/whatever that extends the site selector
once this is done, a set of patterns for using angular-js in Piwik should be observable.
Metadata
Metadata
Assignees
Labels
MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.TaskIndicates an issue is neither a feature nor a bug and it's purely a "technical" change.Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.