Cleanup tests #2 #7753
Merged
Cleanup tests #2 #7753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchezzzhak
approved these changes
Aug 1, 2024
sgiehl
reviewed
Aug 1, 2024
| @@ -5188,9 +5188,9 @@ | |||
| client: | |||
| type: browser | |||
| name: CCleaner | |||
| version: "99.0.4844.51" | |||
| version: 99.0.4844.51 | |||
There was a problem hiding this comment.
This might actually cause problems for some of the forks to other languages. If I remember correctly some yaml parsers try to handle that as number when the " are left away.
There was a problem hiding this comment.
It was me who reported a problem with float values for versions #7633
version: 99.0 nodejs convert to number result 99
version: 99.1 nodejs convert to number result 99.1
version: "99.1" nodejs convert to string result 99.1
version: 99.0.4844.51 nodejs convert to string result 99.0.4844.51
we have long replaced the versions for the formats and there were no complaints that something was broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #7652.
oss.yml- was missing from the script (#7752).clienthints.yml- I forgot to clean this file in the initial PR.The other commits are cleanups for commits merged after the initial PR.