@liviuconcioiu the double quotes around the version numbers had been added on purpose at some point. If I remember correctly some of the forks had problems with parsing the yml files otherwise, as the built in yml parser couldn't parse it without.

@liviuconcioiu the double quotes around the version numbers had been added on purpose at some point. If I remember correctly some of the forks had problems with parsing the yml files otherwise, as the built in yml parser couldn't parse it without.

So what do you suggest to do in this case? Should I add double quotes to all versions? Right now there's a mix and I want to fix this.

Also see @sanchezzzhak comment here #7636 (comment)

Also see @sanchezzzhak comment here #7636 (comment)

the comment applies to the yaml parser we are using in php, as it automatically tries to determine the type.
I would personally say we should add surrounding " to all values that are a string, but might contain numerous values.

I use a very strict YAML parser in nodejs
for example a format fixture

-
  user_agent: Android 12.0
  os: 
    name: Android
    version: 12.0 

nodejs parse result:

   {
        user_agent: "Android 12.0",
        os: {
            name: "Android",
            version: 12  // Number type
       }
   }

php parse result:

   [
        "user_agent"  =>  "Android 12.0",
        "os" => [
            "name": "Android",
            "version": "12.0"
       ]
   ]

the current fixtures are all fixed and at the moment I am satisfied, as they do not give errors in the tests
https://github.com/sanchezzzhak/node-device-detector/actions/runs/8597281681/

total:
you don't need to redo everything now, just make sure that if there is a float/int value in the fixtures, it should be wrapped in quotation marks.
if there are square brackets in the string, this value should also be wrapped in a string.
if you use the script php misc/test.php "useragent" there will never be any problems, he creates the fixtures perfectly.

the script php misc/test.php "useragent" there will never be any problems, he creates the fixtures perfectly.

This PR will do exactly this, so all tests are similar in formatting.