Skip to content

Detect Open Browser fast 5G #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Detect Open Browser fast 5G #7220

merged 3 commits into from
Aug 23, 2022

Conversation

Simbiat
Copy link
Contributor

@Simbiat Simbiat commented Aug 23, 2022

Changed name for com.wOpenBrowser_12576500 (https://play.google.com/store/apps/details?id=com.wOpenBrowser_12576500), since it does not seem related to com.wOpenbrowser_13506467 (https://play.google.com/store/apps/details?id=com.wOpenbrowser_13506467) and does have slightly different name on Google Play.

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

Changed name for `com.wOpenBrowser_12576500` (https://play.google.com/store/apps/details?id=com.wOpenBrowser_12576500), since it does not seem related to `com.wOpenbrowser_13506467` (https://play.google.com/store/apps/details?id=com.wOpenbrowser_13506467) and does have slightly different name on Google Play.
@liviuconcioiu
Copy link
Collaborator

Hi @Simbiat! You should also add the browser here Parser/Client/Browser.php and a test here Tests/Parser/Client/fixtures/browser.yml

@Simbiat
Copy link
Contributor Author

Simbiat commented Aug 23, 2022

Done. Let me know if I need to add/correct something, since this is my first time committing to DD

@liviuconcioiu
Copy link
Collaborator

Everything is okay.

@sanchezzzhak sanchezzzhak changed the title Open Browsers name adjustment Detect Open Browser fast 5G Aug 23, 2022
@sanchezzzhak sanchezzzhak merged commit 27becea into matomo-org:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants