-
Notifications
You must be signed in to change notification settings - Fork 495
Detect devices for existing brands and Detect Pi Browser #7131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(PMT3997), SmartKids Up (PMT3104), MultiPad Wize 1157 4G (PMT1157), Wize 1107 4G (PMT1107)
feat(device) detect brand OnePlus: 10 Pro (NE2211) feat(device) detect brand ZTE: Blade A71 feat(device) detect brand OPPO: F21 Pro (CPH2341) feat(device) detect brand Motorola: Moto G52, Edge 30 Pro
feat(client) detect Pi Browser
feat(device) detect brand Huawei: Honor X7 (CMA-LX1, CMA-LX2, CMA-LX3)
… (TECNO KG5j, TECNO KG5k), Camon 18 (TECNO CH6h), Pop 5 LTE (TECNO BD4i) feat(device) detect brand Huawei: Honor X8 (TFY-LX2) feat(device) detect brand Unimax: U696CL feat(device) detect brand Vivo: Y21a (V2149), Y33t (V2146), T1 4G (V2153), T1 Pro 5G (V2151)
…mi 10A (220233L2G), 11i HyperCharge 5G (21091116UI) feat(device) detect brand Philco: Hit P13 feat(device) detect brand Orange: Nola Fun feat(device) detect brand Honeywell: ScanPal EDA52 feat(device) detect brand Advan: Sketsa 2 feat(device) detect brand Samsung: Galaxy Tab S8+ 12.4" 5G (SM-X808U) feat(device) detect brand Realme: Narzo 50A Prime (RMX3516), C35 (RMX3511), C31 (RMX3501), GT 2 Pro (RMX3301), GT 2 (RMX3312), 9 (RMX3521), 9 Pro+ 5G (RMX3392)
liviuconcioiu
requested changes
May 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanchezzzhak can you add Pi Browser to client hints too? And also, a link for the browser https://play.google.com/store/apps/details?id=pi.browser
'pi.browser': 'Pi Browser'
liviuconcioiu
previously approved these changes
May 29, 2022
@sanchezzzhak would you mind resolving the conflicts? |
sgiehl
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.