Detect devices for existing brands #7122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(device) detect brand Logicom: Le Pulse, Le Prime feat(device) detect brand Xiaomi:Redmi Note 8T (willow) fix(os) fixed warning: Operations priority might differ from what you expect
feat(device) detect brand Logicom: La Tab 292 feat(device) detect brand DEXP: Ursus H410, Ursus H370 feat(device) detect brand iHunt: Alien X Pro (2021) feat(device) detect brand POCO: X4 Pro 5G (2201116PG)
feat(device) detect brand Doogee: S59 feat(device) detect brand DEXP: Ursus S770i
feat(device) detect brand Gigabyte: Boston 4G
feat(device) detect brand Oysters: Life 4G feat(device) detect brand Qilive: Q1-21
feat(device) detect new brand Quest: Raptor feat(device) detect brand Thomson: TEOX103 feat(device) detect brand TOSCIDO: T13 feat(device) detect brand JAY-Tech: Tablet PC G1010 feat(device) detect brand Xiaomi: 12X (2112123AG)
…i Note 10S (rosemary), Redmi 10C (220333QAG, 220333QNY) feat(device) detect brand OnePlus: 10 Pro (NE2215) feat(device) detect brand Realme: Q3t (RMX3462)
feat(device) detect brand Gionee: P61 feat(device) detect brand Xiaomi: Black Shark 4 Pro (SHARK KSR-H0)
sanchezzzhak
commented
May 18, 2022
| '17' => 'FarEasTone', | ||
| '9R' => 'FaRao Pro', | ||
| 'FB' => 'Fantec', | ||
| 'FAC' => 'Facetel', |
There was a problem hiding this comment.
Please note that the 2-character shortcodes have ended.
Can we transfer $deviceBrands to YML file?
There was a problem hiding this comment.
I actually don't see much benefit in moving this to a yml file. It will actually only add ann additional yml parsing, which might slow down the detection more.
Regarding three character shortcodes:
I need to check if Matomo is able to handle them properly before we can merge and release a new version. At least the database is able to store them already, but not sure if the code expects two chars somewhere. Need to investigate that. Meanwhile it might be better to focus on adding devices for already existing brands, as we can merge such PRs.
There was a problem hiding this comment.
OK, I will move new brands from this PR in new branch #7129
feat(device) detect brand Crosscall: Core-M4 Go feat(device) detect brand Qilive: QT19101 feat(device) detect brand PolarLine: 55PU11TC-SM
feat(device) detect brand PolarLine: 24PL51TC-SM feat(device) detect brand Logicom: L-ixir Tab 1047 HD feat(device) detect brand SFR: StarAddict 6 feat(device) rename models for SFR brand: Staraddict 3 => StarAddict , Staraddict => StarAddict, Staraddict 2 => StarAddict 2 etc.
chore: move LNMBBS brand to new branch
# Conflicts: # Parser/Device/AbstractDeviceParser.php # Tests/fixtures/tv-1.yml # regexes/device/mobiles.yml
…rands to new branch
sgiehl
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.