Optimise devices detection for apple #7193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the greedy regular expressions with all the values that fail.
before the changes, the detection speed was (with the turbo fan turned on)
detector.parseDevice (deviceIndexes on) x 423 ops/sec ±1.19% (88 runs sampled)
detector.detect (indexes on) x 350 ops/sec ±0.79% (88 runs sampled)
after:
detector.parseDevice (deviceIndexes on) x 2,721 ops/sec ±2.06% (89 runs sampled)
detector.detect (indexes on) x 1,048 ops/sec ±2.95% (85 runs sampled)
on the second cycle, we have become 6.4 times faster.