I don't have a strong opinion either way, but wouldn't it be good to have this consistent with the browser family?

This is how I fetch the data on https://devicedetector.lw1.at/

https://github.com/Findus23/devicedetector.net/blob/c4ba72bb401504b4980d3e0d8f7eef4c414dbf97/public/ua.php#L42-L48

I need to use OperatingSystem::getOsFamily($dd->getOs('short_name')) construction (the same is for browser family)

I'm writing facade for device detector in my project as Symfony bundle and have construction like:

class DeviceDetectorFacade
{
    private DeviceDetector $deviceDetector;

    public function __construct(DeviceDetector $deviceDetector)
    {
        $this->deviceDetector = $deviceDetector;
    }

    public function getUserAgentInfo(string $userAgent): UserAgentInfo
    {
        // use DeviceDetector
    }
}

So I need to inject or just statically call OperationSystem::getOsFamily
That is not good because OperatingSystem class is just a parser but not a component service so I don't want to inject it. More of that I don't want to call it statically to have hidden dependency

PR's target to save DeviceDetector class as only entrypoint to the component.
The same refactoring may be done for BrowserFamily

@Khutorny Thanks for creating the PR. Would you mind catching up @Findus23 suggestion and apply similar changes to the browser parser? So family is included in the default result so this is kind of consistent?

Of course I can make changes for Browser parser too.
Just tell me to do that in this PR as next commit or in separate PR?

It's fine to simply add it to this PR

@sgiehl @sanchezzzhak
I've added browser family to Browser parse result.
Also I've sorted browsers in browser families list alphabetically for easily searching
All tests passed.

But I haven't added family to tests fixtures.
So there is a construction in BrowserTest like

unset($browser['short_name']);
unset($browser['family']);

I don't like that, but for now left as is.

If you like I can add new browser_full.yaml file with full response structure for some user agents and write separate test or test method for that case without unsets and deprecate current realization. In future it is possible to migrate all user agents to full scheme but there is a lot of 'monkey work' to add short_name and family to almost 500 cases

If you like I can add new browser_full.yaml file with full response structure for some user agents and write separate test or test method for that case without unsets and deprecate current realization. In future it is possible to migrate all user agents to full scheme but there is a lot of 'monkey work' to add short_name and family to almost 500 cases

to the current file device-detector/Tests/Parser/Client/fixtures/browser.yml , to save the editing history
as it was done in oss. yml

short_name does not need to be added.
we are slowly getting rid of this property, in the future when it is not needed at all, it will be deleted.

Added browser family to browser.yaml cases